Move make offset map to load stage #134
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: foxspy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@foxspy 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
|
/kind bug |
|
/run-e2e |
| @@ -320,15 +319,13 @@ IvfIndexNode<T>::Train(const DataSet& dataset, const Config& cfg) { | |||
| index = std::make_unique<faiss::IndexIVFScalarQuantizer>(qzr, dim, nlist, faiss::QuantizerType::QT_8bit, | |||
| metric.value()); | |||
| index->train(rows, (const float*)data); | |||
| index->make_direct_map(true); | |||
There was a problem hiding this comment.
We don't need this for SQ and PQ
There was a problem hiding this comment.
limited the making operation by having raw data or not
Signed-off-by: xianliang <xianliang.li@zilliz.com>
foxspy
force-pushed
the
fix_concurrent_getvector_2
branch
from
039615b
to
a2b2696
Compare
|
/lgtm |
issue: #132
Delete Making map at
getVectorswill cause unexpected error for existing ivf index, because these indexes have nodirect_mapin the binary set. So just move the making operation to load stage to supportgetVectorsfrom existing indexes.